There are elm_widget_theme/theme_set/theme_get functions.
In Eolian these functions will be described as "theme" method and
"theme" property. There is clash here.
So add suffix "_apply" to Eo API for "elm_widget_theme".
Summary:
Gengrid _item_show_region function calculate gengrid x, y moving postion with scroll to type.
Belows are summaries of this refactoring works.
1. Refactoring recalculation of scroll type.
2. Bug fix :
- when x or y is 0, y or x value is set as default value, it->position-1.
- when x or y is less then 1, calculation is not correct.
- make calculate correct position of y when even though scroll direction is horiziontal
(when virtical, x is also calculation correct position).
3. change smart data variable s_type to scroll_to_type to make unity on gen widget.
(genlist smart data variable name is scroll_to_type);
Reviewers: seoz, Hermet, raster
Reviewed By: raster
CC: bluezery
Differential Revision: https://phab.enlightenment.org/D474
Being annoyed by different types of eina critical macros - CRI, CRIT,
CRITICAL -, I concluded to unify them to one. Discussed on IRC and
finally, CRI was chosen to meet the consistency with other macros -
ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
Scrollto positions are divided 4 type
NONE : do not scrollto.
TOP : scrollto position is always top viewport.
MIDDLE : scrollto position is always middle of viewport.
IN : scrollto position to fully visible in viewport.
Summary:
Some applications like file viewer allow multiple selection only with
Control key was pressed.
Reviewers: seoz, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D251
Conflicts:
ChangeLog
NEWS
"index,update" signal is missing in signal description.
So, This patch refactored signal declarations to avoid mistakes.
It was introduced since b430c07ca1f1.
I splited ELM_SAFE_FREE refactoring patches. One commit per each file as recommended.
For the detail, please refer 3072dab12f12fe83fb5a628d15efd5cded11787f.
There are pros and cons but this
1. reduces human mistakes.
2. enhances readability.
3. enhances code quality.
4. removes future bug.
5. was adopted from enlightenment.
This is not all. I will work on enhancing elementary more and more.
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
When the scroller is resized, the signals("elm,action,scroll", "elm,edge,top" so on) shouldn't be sent,
because it's not a scroll-action. So in this case, the content_pos_set should be called without the signals.
Subject: [E-devel] [BUG] [ELM] [PATCH] Bug fixes for APIs
elm_gengrid_region_show/bring_in
Please review the attached patches.
Attached patch "elm_gengrid.patch" which fix the bug related to
elm_gengrid_region_show/bring_in APIs.
And patch "test_gengrid.patch" in order to test the fix.
Change Description:
1. An internal function _item_show_region() is created which does
the
calculation for item position.
2. This function is called in _calc_job() as soon as pan
object
gets its
size.
3. Test_gengrid code enhancement for testing the fix.
SVN revision: 82063
+ elm_access_object_register();
+ elm_access_object_unregister();
+ elm_access_text_set();
+ elm_access_text_get();
+ elm_access_cb_set();
These APIs are to use edje part, evas object as an accessible object.
and do not create access object, because access object would be created at run time.
This is different with internal API _elm_access_object_register();
SVN revision: 81659
On Fri, Oct 19, 2012 at 12:30 PM, Bluezery <ohpowel@gmail.com> wrote:
> Dear all,
>
> There is a bug, invalid data assign into ecore_job.
> Trivial whilte space removal is included also. it's automated in my editor :D.
>
> Please review this patch.
>
> --
> BRs,
> Kim.
SVN revision: 78221
Subject: [E-devel] [patch][elementary] * access *
Series of of pathes from kim shinwoo. looked good to me - so in they
go, finishing off some more access mode to be more complete.
SVN revision: 75415
Subject: [E-devel] [patch] elm_gengrid - add item_select_mode_set/get
apis
I made a item_select_mode_set/get in elm_gengrid.
It works like genlist_item_select_mode apis.
+EAPI void
+elm_gengrid_item_select_mode_set(Elm_Object_Item *it,
+ Elm_Object_Select_Mode mode)
+EAPI Elm_Object_Select_Mode
+elm_gengrid_item_select_mode_get(const Elm_Object_Item *it)
from this morning - left over from last night.
SVN revision: 69056
Subject: [E-devel] [patch] elm_genlist - fix typos and remove
display_only variable
I found a mistake in example. and display_only value is remained.
It's fixed some trivial errors.
SVN revision: 69000
Subject: [E-devel] [patch] elm_gengrid - add item_index_get func
I made a patch that's adding elm_gengrid_item_index_get function.
+EAPI int
+elm_gengrid_item_index_get(const Elm_Object_Item *it)
It works like elm_genlist_item_index_get()
SVN revision: 68951
Subject: [E-devel] [patch] elm_gen{list, grid} - add
no_highlight_mode_set/get
actually change it to hilight_mode/set/get with the inverse.
SVN revision: 68947
Subject: [E-devel] [patch] elm_gen{list, grid} - add elm_genlist_select_mode_set
As discussed in irc, I made a patch about unifying
always_select_mode_set and no_select_mode_set.
I'm introducing two apis in genlist (also in gengrid)
+EAPI void
+elm_genlist_select_mode_set(Evas_Object *obj,
Elm_Object_Select_Mode_Type mode)
+EAPI Elm_Object_Select_Mode_Type
+elm_genlist_select_mode_get(const Evas_Object *obj);
And added a enum in elm_general.h
+typedef enum
+{
+ ELM_OBJECT_NORMAL_SELECT = 0, /**< default select mode */
+ ELM_OBJECT_ALWAYS_SELECT, /**< always select mode */
+ ELM_OBJECT_NO_SELECT, /**< no select mode */
+
+ ELM_OBJECT_SELECT_MODE_MAX
+} Elm_Object_Select_Mode_Type;
After this is commited, i'll send a patch about examples and
edje_external.
SVN revision: 68937