Focus should be not lost when un-fullscreen or un-maximize a window #5

New Issue

Thanatermesis · 2022-12-08T15:38:22-08:00

Thanatermesis commented

2022-12-08 15:38:22 -08:00

This is a very small issue on which I have been affected in different ways, basically when you un-fullscreen a window, the focus is changed to another one, this is a demo of how it is happening:

https://youtu.be/n1d8_phwJDQ

Note: on the video I don't mention "un-maximize" but is the same issue, if i maximize a window, and then un-maximize it, my focus is lost into another window sometimes

This is a very small issue on which I have been affected in different ways, basically when you un-fullscreen a window, the focus is changed to another one, this is a demo of how it is happening: https://youtu.be/n1d8_phwJDQ Note: on the video I don't mention "un-maximize" but is the same issue, if i maximize a window, and then un-maximize it, my focus is lost into another window sometimes

kw was assigned by Thanatermesis

2022-12-08 15:38:31 -08:00

triantares commented

2022-12-09 03:39:58 -08:00

I've got my focus set to 'click to focus' and this doesn't happen.
So it likely has to be in the focus setting there.

I've got my focus set to 'click to focus' and this doesn't happen. So it likely has to be in the focus setting there.

kw referenced this issue from a commit

2022-12-09 07:12:06 -08:00

focus: Keep focus when un-fullscreened

kw commented

2022-12-09 07:16:25 -08:00

I have pushed a fix that seems to work for me in the un-fullscreen case.

Un-maximize should already keep focus by warping the pointer. Seems to work for me.

I have pushed a fix that seems to work for me in the un-fullscreen case. Un-maximize should already keep focus by warping the pointer. Seems to work for me.

Thanatermesis commented

2022-12-09 09:51:15 -08:00

@triantares not exactly: the "click to focus" option doesn't set the focus by itself, it requires the user to do it, the other 2 options are a "auto" way to set the focus following where is your mouse pointer, the issue was that when you de-maximize/de-fullscreen , the mouse can be located somewhere touching another window (and so your focus is lost into another window) where is meant to keep the focus on the same one on this action

@kw verified and working, thank you :)

@triantares not exactly: the "click to focus" option doesn't set the focus by itself, it requires the user to do it, the other 2 options are a "auto" way to set the focus following where is your mouse pointer, the issue was that when you de-maximize/de-fullscreen , the mouse can be located somewhere touching another window (and so your focus is lost into another window) where is meant to keep the focus on the same one on this action @kw verified and working, thank you :)

Thanatermesis closed this issue

2022-12-09 09:51:17 -08:00

Thanatermesis commented

2022-12-09 12:23:22 -08:00

Note: there's a similar issue that still happens on this condition:

make sure you don't have the last checkbox enabled in the focus settings "send mouse pointer to window after focus switch"
open a terminal in top-left corner
open another in the center of the screen, put your mouse location here
press alt-tab (focus is moved to the other terminal, but not your mouse)
run a normal application from it (like, thunar)
close the application
your focus is moved to the other terminal

this issue happens because has not relation with the de-fullscreen state, but still, should E16 remember the "parent focus" and return the focus to it when its children (or "next") application focus is lost?

Note: there's a similar issue that still happens on this condition: * make sure you don't have the last checkbox enabled in the focus settings "send mouse pointer to window after focus switch" * open a terminal in top-left corner * open another in the center of the screen, put your mouse location here * press alt-tab (focus is moved to the other terminal, but not your mouse) * run a normal application from it (like, thunar) * close the application * your focus is moved to the other terminal this issue happens because has not relation with the de-fullscreen state, but still, **should E16 remember the "parent focus" and return the focus to it when its children (or "next") application focus is lost?**

kw commented

2022-12-10 00:16:57 -08:00

I don't think I agree here. In this case e16 does what sloppy/pointer focus does - focus the window in which the pointer is.
I think this is straightforward to understand and accept as a user. If in stead the window that previously had focus was focused I think that one might wonder why some particular window that doesn't contain the pointer is focused.
Focusing windows that don't contain the pointer in sloppy focus mode is already questionable, IMO. But e16 allows that when switching focus (or it can warp the pointer too and not violate that principle).

I don't think I agree here. In this case e16 does what sloppy/pointer focus does - focus the window in which the pointer is. I think this is straightforward to understand and accept as a user. If in stead the window that previously had focus was focused I think that one might wonder why some particular window that doesn't contain the pointer is focused. Focusing windows that don't contain the pointer in sloppy focus mode is already questionable, IMO. But e16 allows that when switching focus (or it can warp the pointer too and not violate that principle).

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: e16/e16#5