enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 1 Projects Releases Wiki Activity

Revert "genlist: recalc item size after item content field updated" 

This reverts commit b48d3eb04e.

This patch can be occurred performance issue.
update is needed for only non-homogeneous case.
I'll revert patch and update new patch in phabricator for check.
This commit is contained in:
SangHyeon Lee 2016-04-28 16:00:00 +09:00
parent 5f7f59b3d8
commit 0181a940f1
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/lib/elementary/elm_genlist.c
View File

@ -7094,9 +7094,8 @@ _elm_genlist_item_fields_update(Eo *eo_item EINA_UNUSED, Elm_Gen_Item *it,
&GL_IT(it)->deco_all_contents,
"contents", parts);
}
//forcely recalc about item because even same content, size can be changed.
it->item->mincalcd = EINA_FALSE;
it->item->block->must_recalc = EINA_TRUE;
if (it->has_contents != (!!it->contents))
it->item->mincalcd = EINA_FALSE;
it->has_contents = !!it->contents;
if (it->item->type == ELM_GENLIST_ITEM_NONE)
{
@ -7113,10 +7112,7 @@ _elm_genlist_item_fields_update(Eo *eo_item EINA_UNUSED, Elm_Gen_Item *it,
_item_state_realize(it, VIEW(it), parts);
if (!it->item->mincalcd)
{
ELM_SAFE_FREE(it->item->wsd->calc_job, ecore_job_del);
it->item->wsd->calc_job = ecore_job_add(_calc_job, it->item->wsd->obj);
}
elm_genlist_item_update(eo_item);
}
EOLIAN static void