enlightenment/efl
enlightenment
/
efl
8
7
Fork 15
Code Issues 13 Pull Requests 2 Projects Releases Wiki Activity

combobox: fix continuous clicks on hover 

Summary:
Continouous clicks on hover would need to ensure that variable
on_dismiss of combobox_vertical style in hover.edc should 0 when slot is being shown, otherwise events
would be disabled on hover even though swallow content is shown.

@fix

Signed-off-by: Divyesh Purohit <purohit.div@gmail.com>

Test Plan:
Click continouosly on combobox and events on hover would be
disabled.

Reviewers: cedric

Differential Revision: https://phab.enlightenment.org/D3601

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
This commit is contained in:
Divyesh Purohit 2016-01-26 13:01:03 -08:00 committed by Cedric BAIL
parent 3af4a727cc
commit 04cff68f41
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
legacy/elementary/data/themes/edc/elm/hover.edc
View File

@ -479,6 +479,7 @@ group { name: "elm/hover/base/hoversel_vertical/default";
else
run_program(PROGRAM:"topshow_right");
set_int(visible, 1);
set_int(on_dismiss, 0);
}
public bottomshow2() {
if (get_int(right) == 0)
@ -486,6 +487,7 @@ group { name: "elm/hover/base/hoversel_vertical/default";
else
run_program(PROGRAM:"bottomshow_right");
set_int(visible, 1);
set_int(on_dismiss, 0);
}
}
parts {

4
legacy/elementary/src/lib/elc_combobox.c
View File

@ -225,7 +225,7 @@ _gl_filter_finished_cb(void *data, Eo *obj EINA_UNUSED,
if (sd->count > 0)
{
if (!sd->expanded) _activate(data);
if (!sd->expanded) _activate(data);
else _table_resize(data);
}
else elm_combobox_hover_end(data);
@ -237,7 +237,7 @@ _on_aborted(void *data, Eo *obj EINA_UNUSED,
const Eo_Event_Description *desc EINA_UNUSED, void *event_info EINA_UNUSED)
{
ELM_COMBOBOX_DATA_GET(data, sd);
if (sd->expanded == EINA_TRUE) elm_combobox_hover_end(data);
if (sd->expanded) elm_combobox_hover_end(data);
return EINA_TRUE;
}