From 05950e093c0aa51e3dd56426b67f9cc2a2499db7 Mon Sep 17 00:00:00 2001 From: Hermet Park Date: Fri, 8 Jan 2016 20:50:01 +0900 Subject: [PATCH] hoversel: don't activate if the items were none. it's wierd to expand hoversel without items. the behavior made me suprised before i analyzed it. it looked almost a bug. if you have any other objections, please ping me. --- legacy/elementary/src/lib/elc_hoversel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/legacy/elementary/src/lib/elc_hoversel.c b/legacy/elementary/src/lib/elc_hoversel.c index 51625da768..175e1fb9c2 100644 --- a/legacy/elementary/src/lib/elc_hoversel.c +++ b/legacy/elementary/src/lib/elc_hoversel.c @@ -421,6 +421,7 @@ _activate(Evas_Object *obj) sd->expanded = EINA_TRUE; if (elm_widget_disabled_get(obj)) return; + if (!sd->items) return; sd->hover = elm_hover_add(sd->hover_parent); elm_widget_sub_object_add(obj, sd->hover); @@ -794,7 +795,6 @@ _elm_hoversel_item_add(Eo *obj, Elm_Hoversel_Data *sd, const char *label, const snprintf(buf, sizeof(buf), "hoversel_vertical_entry/%s", elm_widget_style_get(obj)); - VIEW(item) = bt = elm_button_add(obj); elm_widget_mirrored_set(bt, elm_widget_mirrored_get(obj)); elm_object_style_set(bt, buf);