enlightenment/efl
enlightenment
/
efl
8
7
Fork 15
Code Issues 12 Pull Requests 1 Projects Releases Wiki Activity

ecore-evas: Fix error handling issues in wayland_shm engine 

This patch fixes 2 Coverity issues where engine_info_set was being
called, but the return was never being checked.

Fixes Coverity CID1357141 and CID1357142

@fix

Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
This commit is contained in:
Chris Michael 2016-06-30 10:51:29 -04:00
parent 837108050b
commit 1fb3c33286
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c
View File

@ -443,7 +443,8 @@ _ecore_evas_wl_show(Ecore_Evas *ee)
if ((!einfo->info.wl_surface) || (einfo->info.wl_surface != surf))
{
einfo->info.wl_surface = surf;
evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo);
if (!evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo))
ERR("Failed to set Evas Engine Info for '%s'", ee->driver);
evas_damage_rectangle_add(ee->evas, 0, 0, ee->w + fw, ee->h + fh);
}
}
@ -482,7 +483,10 @@ _ecore_evas_wl_hide(Ecore_Evas *ee)
if (einfo)
{
einfo->info.wl_surface = NULL;
evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo);
if (!evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo))
{
ERR("Failed to set Evas Engine Info for '%s'", ee->driver);
}
}
if (wdata->win)