enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

elm/popup: remove del callback for internal table object during destruction 

Summary:
the table object's destruction is no longer relevant after this point and
its callback can trigger unnecessary errors

@fix
Depends on D8986

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8988
This commit is contained in:
Mike Blumenkrantz 2019-05-29 09:29:45 -04:00
parent 3f3582af26
commit 282c7672f6
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/lib/elementary/elc_popup.c
View File

@ -234,7 +234,7 @@ _focus_changed_popup(void *data, const Efl_Event *ev)
EFL_CALLBACKS_ARRAY_DEFINE(composition_cb,
{ EFL_UI_FOCUS_OBJECT_EVENT_FOCUS_CHANGED, _focus_changed_popup },
)
static void _on_table_del(void *data, Evas *e, Evas_Object *obj, void *event_info);
EOLIAN static void
_elm_popup_efl_canvas_group_group_del(Eo *obj, Elm_Popup_Data *sd)
{
@ -248,6 +248,9 @@ _elm_popup_efl_canvas_group_group_del(Eo *obj, Elm_Popup_Data *sd)
evas_object_event_callback_del
(sd->content, EVAS_CALLBACK_DEL, _on_content_del);
evas_object_event_callback_del(obj, EVAS_CALLBACK_SHOW, _on_show);
if (sd->tbl)
evas_object_event_callback_del_full(sd->tbl, EVAS_CALLBACK_DEL,
_on_table_del, obj);
efl_event_callback_array_del(sd->notify, composition_cb(), obj);
sd->last_button_number = 0;