enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 1 Projects Releases Wiki Activity

elc_fileselector: Fix memory leak in _selected_set. 

Using ecore_file_dir_get() like this will leak the returned string as we
have no way to control its free'ing. Better use a separate variable for it.
This commit is contained in:
Stefan Schmidt 2013-06-10 15:47:54 +01:00
parent 125938e968
commit 33eca6e2c0
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
legacy/elementary/src/lib/elc_fileselector.c
View File

@ -1236,6 +1236,7 @@ _selected_set(Eo *obj, void *_pd, va_list *list)
{
const char *_path = va_arg(*list, const char *);
Eina_Bool *ret = va_arg(*list, Eina_Bool *);
char *selected;
if (ret) *ret = EINA_TRUE;
char *path;
@ -1253,8 +1254,10 @@ _selected_set(Eo *obj, void *_pd, va_list *list)
goto clean_up;
}
_populate(obj, ecore_file_dir_get(path), NULL);
eina_stringshare_replace(&sd->selection, path);
selected= ecore_file_dir_get(path);
_populate(obj, selected, NULL);
eina_stringshare_replace(&sd->selection, path);
free(selected);
}
clean_up: