From 3716e9b12c237b5fcd8c6235f2f61244f8d177b7 Mon Sep 17 00:00:00 2001 From: Stefan Schmidt Date: Wed, 19 Mar 2014 16:46:36 +0100 Subject: [PATCH] eo: Make sure we have a va_end matching the va_start before returning. Was fien on the normal path but missing on the error path. Also remove the spurious break after the return. Would never be reached. Looks like a copy and paste bug to me. CID 1187638 --- src/lib/eo/eo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c index 39b5abfc0d..17b453cda2 100644 --- a/src/lib/eo/eo.c +++ b/src/lib/eo/eo.c @@ -834,8 +834,8 @@ eo_class_new(const Eo_Class_Description *desc, const Eo_Class *parent_id, ...) case EO_CLASS_TYPE_REGULAR_NO_INSTANT: ERR("Regular non-instantiable classes ('%s') aren't allowed in class ('%s') extension list", extn->desc->name, desc->name); + va_end(p_list); return NULL; - break; case EO_CLASS_TYPE_REGULAR: case EO_CLASS_TYPE_INTERFACE: case EO_CLASS_TYPE_MIXIN: