enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 1 Projects Releases Wiki Activity

efl_ui_win: Fix dereference null return value 

Summary:
Coverity reports efl_data_scope_safe_get returns NULL here (checked
273 out of 285 times). Add an EINA_SAFETY check here for a null return.

Fixes Coverity CID1399428

@fix

Depends on D8345

Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8346
This commit is contained in:
Christopher Michael 2019-03-15 08:57:34 -04:00
parent 1688b5d511
commit 384d960852
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/lib/elementary/efl_ui_win.c
View File

@ -8845,6 +8845,7 @@ elm_win_keygrab_set(Elm_Win *obj, const char *key,
Eina_Bool ret = EINA_FALSE;
#ifdef HAVE_ELEMENTARY_X
Efl_Ui_Win_Data *sd = efl_data_scope_safe_get(obj, MY_CLASS);
EINA_SAFETY_ON_NULL_RETURN_VAL(sd, EINA_FALSE);
_internal_elm_win_xwindow_get(sd);
if (sd->x.xwin)
{