enlightenment/efl
enlightenment
/
efl
8
7
Fork 15
Code Issues 12 Pull Requests 2 Projects Releases Wiki Activity

color class lookup speedups by using stringshare properties. 

with stringshare, we can just compare pointers instead of
strcmp. Since we'll need the stringshare later, this is a good
optimization.



SVN revision: 46925
This commit is contained in:
Gustavo Sverzut Barbieri 2010-03-07 04:50:12 +00:00
parent 5463f0c5d3
commit 40a7b9aa38
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
legacy/edje/src/lib/edje_util.c
View File

@ -661,10 +661,14 @@ edje_object_color_class_set(Evas_Object *obj, const char *color_class, int r, in
else if (b > 255) b = 255; else if (b > 255) b = 255;
if (a < 0) a = 0; if (a < 0) a = 0;
else if (a > 255) a = 255; else if (a > 255) a = 255;
color_class = eina_stringshare_add(color_class);
if (!color_class) return EINA_FALSE;
EINA_LIST_FOREACH(ed->color_classes, l, cc) EINA_LIST_FOREACH(ed->color_classes, l, cc)
{ {
if ((cc->name) && (!strcmp(cc->name, color_class))) if (cc->name == color_class)
{ {
eina_stringshare_del(color_class);
if ((cc->r == r) && (cc->g == g) && if ((cc->r == r) && (cc->g == g) &&
(cc->b == b) && (cc->a == a) && (cc->b == b) && (cc->a == a) &&
(cc->r2 == r2) && (cc->g2 == g2) && (cc->r2 == r2) && (cc->g2 == g2) &&
@ -693,13 +697,12 @@ edje_object_color_class_set(Evas_Object *obj, const char *color_class, int r, in
} }
} }
cc = malloc(sizeof(Edje_Color_Class)); cc = malloc(sizeof(Edje_Color_Class));
if (!cc) return EINA_FALSE; if (!cc)
cc->name = eina_stringshare_add(color_class);
if (!cc->name)
{ {
free(cc); eina_stringshare_del(color_class);
return EINA_FALSE; return EINA_FALSE;
} }
cc->name = color_class;
cc->r = r; cc->r = r;
cc->g = g; cc->g = g;
cc->b = b; cc->b = b;