From 4250494f11dc53f86f8364ec21fa26ea1f7ae9d2 Mon Sep 17 00:00:00 2001 From: Marcel Hollerbach Date: Fri, 17 Jan 2020 09:49:13 -0500 Subject: [PATCH] efl_ui_suite: fix test code of grid Summary: this test code seemed buggy, we used the iterator *after* the content was changed. Additionally, we freed the iterator with free instead of eina_iterator_free. This fixes test test suite. Depends on D11123 Reviewers: raster, zmike, cedric, segfaultxavi Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11124 --- src/tests/elementary/efl_ui_test_grid.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/tests/elementary/efl_ui_test_grid.c b/src/tests/elementary/efl_ui_test_grid.c index 7ec1763545..db19e58d87 100644 --- a/src/tests/elementary/efl_ui_test_grid.c +++ b/src/tests/elementary/efl_ui_test_grid.c @@ -89,16 +89,15 @@ EFL_START_TEST(efl_ui_grid_unpack_all) ck_assert(grid_item_pack(grid, count_before, NULL) != EINA_FALSE); - itor = efl_content_iterate(grid); efl_pack_unpack_all(grid); count = efl_content_count(grid); ck_assert(count == 0); + itor = efl_content_iterate(grid); EINA_ITERATOR_FOREACH(itor, item) - efl_del(item); - - free(itor); + ck_assert(EINA_FALSE); + eina_iterator_free(itor); } EFL_END_TEST