enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 1 Projects Releases Wiki Activity

edje: Fix unchecked return value 

Coverity reports that we call _circular_dependency_find here without
checking the return value

Fixes Coverity CID1349867

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
This commit is contained in:
Chris Michael 2016-07-21 12:29:35 -04:00
parent 3bc6e30d63
commit 4555f5d594
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/lib/edje/edje_calc.c
View File

@ -3923,18 +3923,22 @@ _edje_part_recalc(Edje *ed, Edje_Real_Part *ep, int flags, Edje_Calc_Params *sta
Eina_List *l = NULL;
char *part_name;
char depends_path[PATH_MAX] = "";
_circular_dependency_find(ed, ep, NULL, &clist);
strncat(depends_path, ep->part->name,
sizeof(depends_path) - strlen(depends_path) - 1);
EINA_LIST_FOREACH(clist, l, part_name)
if (_circular_dependency_find(ed, ep, NULL, &clist))
{
strncat(depends_path, " -> ",
sizeof(depends_path) - strlen(depends_path) - 1);
strncat(depends_path, part_name,
strncat(depends_path, ep->part->name,
sizeof(depends_path) - strlen(depends_path) - 1);
EINA_LIST_FOREACH(clist, l, part_name)
{
strncat(depends_path, " -> ",
sizeof(depends_path) - strlen(depends_path) - 1);
strncat(depends_path, part_name,
sizeof(depends_path) - strlen(depends_path) - 1);
}
ERR("Circular dependency in the group '%s' : %s",
ed->group, depends_path);
eina_list_free(clist);
}
ERR("Circular dependency in the group '%s' : %s", ed->group, depends_path);
eina_list_free(clist);
#endif
return;
}