enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 1 Projects Releases Wiki Activity

From: Otávio Pontes <otavio@profusion.mobi> 

Subject: Re: [E-devel] Transition Layout for elm_box

There are 2 simple problems with the committed code. First, it would
be better to locate the struct _Elm_Box_Transition in elm_box.c
instead of Elementary.h.in, because users should create it with
elm_box_transition_new and changing its contents can be dangerous. And
second, in struct _Transition_Animation_Data, I declared 4 coordinate
variables as int, instead of using Evas_Coords.
I am sending both patches attached.



SVN revision: 52560
This commit is contained in:
Otávio Pontes 2010-09-22 00:33:17 +00:00 committed by Carsten Haitzler
parent 31a6482f50
commit 498de7e94d
2 changed files with 23 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
legacy/elementary/src/lib/Elementary.h.in
View File

@ -470,27 +470,6 @@ extern "C" {
*/
typedef struct _Elm_Box_Transition Elm_Box_Transition;
struct _Elm_Box_Transition
{
double initial_time;
double duration;
Eina_Bool animation_ended:1;
Eina_Bool recalculate:1;
Ecore_Animator *animator;
struct
{
Evas_Object_Box_Layout layout;
void *data;
void(*free_data)(void *data);
} start, end;
void(*transition_end_cb)(void *data);
void *transition_end_data;
void (*transition_end_free_data)(void *data);
Eina_List *objs;
Evas_Object *box;
};
EAPI Evas_Object *elm_box_add(Evas_Object *parent);
EAPI void elm_box_horizontal_set(Evas_Object *obj, Eina_Bool horizontal);

24
legacy/elementary/src/lib/elm_box.c
View File

@ -30,12 +30,34 @@ struct _Widget_Data
Eina_Bool homogeneous:1;
};
struct _Elm_Box_Transition
{
double initial_time;
double duration;
Eina_Bool animation_ended:1;
Eina_Bool recalculate:1;
Ecore_Animator *animator;
struct
{
Evas_Object_Box_Layout layout;
void *data;
void(*free_data)(void *data);
} start, end;
void(*transition_end_cb)(void *data);
void *transition_end_data;
void (*transition_end_free_data)(void *data);
Eina_List *objs;
Evas_Object *box;
};
struct _Transition_Animation_Data
{
Evas_Object *obj;
struct
{
int x, y, w, h;
Evas_Coord x, y, w, h;
} start, end;
};