enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

efl_ui_slack: remove explicit animation removings 

it appears that this is a bit unnessesery. Setting an animator to NULL
only causes the animation to be stopped. However, in all cases of these
removed calls, a new animator is setted anyways in one of the next
calls. Which means, the old animator is going to be stopped and removed
anyways. Thus these calls are unnessesery

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8007
This commit is contained in:
Marcel Hollerbach 2019-02-23 11:05:18 +01:00
parent 005c39b39c
commit 4ccbf201fb
1 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/lib/elementary/efl_ui_stack.c
View File

@ -280,10 +280,6 @@ _efl_ui_stack_push(Eo *obj, Efl_Ui_Stack_Data *pd, Eo *content)
* the content without animation. */
if (top_cd->on_pushing)
{
//Finish current animation.
efl_canvas_object_event_animation_set(top_content,
EFL_GFX_ENTITY_EVENT_SHOW, NULL);
_hide_content_without_anim(obj, top_content);
_announce_hiding(obj, top_content);
}
@ -337,10 +333,6 @@ _efl_ui_stack_pop(Eo *obj, Efl_Ui_Stack_Data *pd)
* the content without animation. */
if (top_cd->on_popping)
{
//Finish current animation.
efl_canvas_object_event_animation_set(top_content,
EFL_GFX_ENTITY_EVENT_SHOW, NULL);
_hide_content_without_anim(obj, top_content);
_announce_hiding(obj, top_content);
}
@ -362,13 +354,6 @@ _efl_ui_stack_pop(Eo *obj, Efl_Ui_Stack_Data *pd)
Content_Data);
Eo *prev_content = prev_cd->content;
//If content is being pushed now, then finish current animation.
if (prev_cd->on_pushing)
{
efl_canvas_object_event_animation_set(prev_content,
EFL_GFX_ENTITY_EVENT_HIDE,
NULL);
}
prev_cd->on_popping = EINA_TRUE;
//Loaded Event