From 551101b4cd74debcaa906fb73f7c60b7a26b550d Mon Sep 17 00:00:00 2001 From: Derek Foreman Date: Fri, 15 Jun 2018 13:18:15 -0500 Subject: [PATCH] ecore_wl2: Set the parent window's surface to NULL on surface destroy Summary: Prevents potential use after free. Depends on D6277 Reviewers: devilhorns, zmike Reviewed By: zmike Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6278 --- src/lib/ecore_wl2/ecore_wl2_surface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/ecore_wl2/ecore_wl2_surface.c b/src/lib/ecore_wl2/ecore_wl2_surface.c index 6ff5f1d57e..78cbc5943f 100644 --- a/src/lib/ecore_wl2/ecore_wl2_surface.c +++ b/src/lib/ecore_wl2/ecore_wl2_surface.c @@ -17,6 +17,7 @@ ecore_wl2_surface_destroy(Ecore_Wl2_Surface *surface) ecore_event_handler_del(surface->offscreen_handler); surface->funcs->destroy(surface, surface->private_data); + surface->wl2_win->wl2_surface = NULL; surface->wl2_win = NULL; free(surface);