From 571d7b6287fde386cc9689aaafea8b8f57b3571b Mon Sep 17 00:00:00 2001 From: Jean-Philippe Andre Date: Fri, 14 Mar 2014 16:55:33 +0900 Subject: [PATCH] Evas filters: Fix invalid error check in mapped_blend() Some filters would not render because I checked the wrong value. image_draw can not fail, it only returns a bool indicating asynchronous processing. --- src/lib/evas/filters/evas_filter_blend.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/lib/evas/filters/evas_filter_blend.c b/src/lib/evas/filters/evas_filter_blend.c index a3aa21c936..1e5260d6f8 100644 --- a/src/lib/evas/filters/evas_filter_blend.c +++ b/src/lib/evas/filters/evas_filter_blend.c @@ -324,12 +324,12 @@ _mapped_blend(void *data, void *drawctx, DBG("blend: %d,%d,%d,%d --> %d,%d,%d,%d (from %dx%d to %dx%d +%d,%d)", 0, 0, sw, sh, dx, dy, cols, rows, sw, sh, dw, dh, dx, dy); - ret = image_draw(data, drawctx, out, in, - sx, sy, cols, rows, // src - dx, dy, cols, rows, // dst - EINA_TRUE, // smooth - EINA_FALSE); // Not async - return ret; + image_draw(data, drawctx, out, in, + sx, sy, cols, rows, // src + dx, dy, cols, rows, // dst + EINA_TRUE, // smooth + EINA_FALSE); // Not async + return EINA_TRUE; } if (fillmode & EVAS_FILTER_FILL_MODE_REPEAT_X) @@ -462,11 +462,10 @@ _mapped_blend(void *data, void *drawctx, col, row, src_x, src_y, src_w, src_h, dst_x, dst_y, dst_w, dst_h, sw, sh, dw, dh); - ret = image_draw(data, drawctx, out, in, - src_x, src_y, src_w, src_h, - dst_x, dst_y, dst_w, dst_h, - EINA_TRUE, EINA_FALSE); - if (!ret) return EINA_FALSE; + image_draw(data, drawctx, out, in, + src_x, src_y, src_w, src_h, + dst_x, dst_y, dst_w, dst_h, + EINA_TRUE, EINA_FALSE); } } return ret;