enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 1 Projects Releases Wiki Activity

Ecore pipe: clean up handling of already read information. 

Coverity was complaining about a possible integer overflow. This isn't
actually possible, but coverity has no way to know that because we were
in fact using a too big of a type. I fixed it to be the right type so
now everything should work.

CID 98384

@fix
This commit is contained in:
Tom Hacohen 2015-10-04 15:34:48 +01:00
parent 0dd60ced44
commit 625eba7d0f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/ecore/ecore_pipe.c
View File

@ -92,7 +92,7 @@ struct _Ecore_Pipe
Ecore_Pipe_Cb handler;
unsigned int len;
int handling;
size_t already_read;
unsigned int already_read;
void *passed_data;
int message;
Eina_Bool delete_me : 1;
@ -656,12 +656,12 @@ _ecore_pipe_read(void *data,
/* catch the non error case first */
/* if we read enough data to finish the message/buffer */
if (ret == (ssize_t)(p->len - p->already_read))
if (ret == (p->len - p->already_read))
_ecore_pipe_handler_call(p, p->passed_data, p->len);
else if (ret > 0)
{
/* more data left to read */
p->already_read += ret;
p->already_read += (unsigned int) ret;
_ecore_pipe_unhandle(p);
return ECORE_CALLBACK_RENEW;
}