enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

elm_atspi_bridge: fix bugs reported by coverity 

Make sure we free allocated resources in the error path.
Prevent usage of uninitilized value.

Signed-off-by: Bartlomiej Grzelewski <b.grzelewski@samsung.com>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11607
This commit is contained in:
Bartlomiej Grzelewski 2020-03-27 11:24:42 +00:00 committed by Stefan Schmidt
parent 3feacb2b66
commit 692d697cc3
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/lib/elementary/elm_atspi_bridge.c
View File

@ -1365,11 +1365,12 @@ _text_string_at_offset_get(const Eldbus_Service_Interface *iface, const Eldbus_M
str = str ? str : strdup("");
ret = eldbus_message_method_return_new(msg);
EINA_SAFETY_ON_NULL_RETURN_VAL(ret, NULL);
EINA_SAFETY_ON_NULL_GOTO(ret, cleanup);
eldbus_message_arguments_append(ret, "sii", str, start, end);
free(str);
cleanup:
free(str);
return ret;
}
@ -1409,11 +1410,12 @@ _text_text_get(const Eldbus_Service_Interface *iface, const Eldbus_Message *msg)
str = str ? str : strdup("");
Eldbus_Message *ret = eldbus_message_method_return_new(msg);
EINA_SAFETY_ON_NULL_RETURN_VAL(ret, NULL);
EINA_SAFETY_ON_NULL_GOTO(ret, cleanup);
eldbus_message_arguments_append(ret, "s", str);
cleanup:
free(str);
return ret;
}
@ -1570,9 +1572,10 @@ _text_attribute_value_get(const Eldbus_Service_Interface *iface, const Eldbus_Me
}
ret = eldbus_message_method_return_new(msg);
EINA_SAFETY_ON_NULL_RETURN_VAL(ret, NULL);
EINA_SAFETY_ON_NULL_GOTO(ret, cleanup);
eldbus_message_arguments_append(ret, "siib", value ? value : "", start, end, res);
cleanup:
free(value);
return ret;
}