enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

eina_value: Fix unchecked return value 

Small patch to check return value of eina_value_type_setup reported by
Coverity

Fixes CID1401023
This commit is contained in:
Christopher Michael 2021-02-25 09:23:23 -05:00
parent 3a07f18294
commit 732e622a82
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/lib/eina/eina_value.c
View File

@ -4614,27 +4614,27 @@ eina_value_optional_pset(Eina_Value *value,
{
eina_value_optional_reset(value);
if(sizeof(Eina_Value_Optional_Outer) <= sizeof(Eina_Value_Union))
if (sizeof(Eina_Value_Optional_Outer) <= sizeof(Eina_Value_Union))
{
Eina_Value_Optional_Outer outer;
outer.subtype = subtype;
outer.value = malloc(subtype->value_size);
eina_value_type_setup(subtype, outer.value);
eina_value_type_pset(subtype, outer.value, subvalue);
if (!eina_value_pset(value, &outer))
{
return EINA_FALSE;
}
Eina_Value_Optional_Outer outer;
outer.subtype = subtype;
outer.value = malloc(subtype->value_size);
if (!eina_value_type_setup(subtype, outer.value))
return EINA_FALSE;
eina_value_type_pset(subtype, outer.value, subvalue);
if (!eina_value_pset(value, &outer))
return EINA_FALSE;
}
else
{
Eina_Value_Optional_Inner *inner =
malloc(sizeof(Eina_Value_Optional_Inner) + subtype->value_size);
inner->subtype = subtype;
eina_value_type_setup(subtype, inner->value);
if (!eina_value_type_setup(subtype, inner->value))
return EINA_FALSE;
eina_value_type_pset(subtype, inner->value, subvalue);
if (!eina_value_pset(value, &inner))
return EINA_FALSE;
return EINA_FALSE;
}
return EINA_TRUE;