enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

Edje: add checking on NULL 3-rd parameter in edje_object_part_external_param_type_get() 

@fix

Summary: add checking on NULL 3-rd parameter (param) before strcmp to avoid segfault

Reviewers: cedric, jpeg, NikaWhite, myoungwoon, Hermet

Reviewed By: Hermet

Subscribers: Hermet, t.naumenko

Differential Revision: https://phab.enlightenment.org/D4424
This commit is contained in:
Artem Popov 2016-11-24 12:13:36 +09:00 committed by Hermet Park
parent 791bdcb7b2
commit 7372b1d156
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/edje/edje_external.c
View File

@ -124,7 +124,7 @@ _edje_object_part_external_param_type_get(Eo *obj, Edje *ed, const char *part, c
Edje_External_Type *type;
Edje_External_Param_Info *info;
if ((!ed) || (!part)) return EDJE_EXTERNAL_PARAM_TYPE_MAX;
if ((!ed) || (!part) || (!param)) return EDJE_EXTERNAL_PARAM_TYPE_MAX;
rp = _edje_real_part_recursive_get(&ed, (char *)part);
if (!rp)
@ -147,7 +147,7 @@ _edje_object_part_external_param_type_get(Eo *obj, Edje *ed, const char *part, c
return EDJE_EXTERNAL_PARAM_TYPE_MAX;
}
for (info = type->parameters_info; info->name; info++)
if (strcmp(info->name, param) == 0) return info->type; ;
if (strcmp(info->name, param) == 0) return info->type;
ERR("no parameter '%s' external type '%s'", param, type->module_name);