enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 1 Projects Releases Wiki Activity

evas: fix invalid read reported in eina_rectangle_pool_free by valgrind. 

Summary:
This fixes an invalid read reported by valgrind in eina_rectangle_pool_free
Reference: T1360

Signed-off-by: Sanjay Nirankari <sanjay.n1@partner.samsung.com>
Signed-off-by: Rajeev Ranjan <rajeev.r@samsung.com>

Reviewers: cedric, raster

Reviewed By: cedric

CC: sreedeep.m, sanjay, cedric

Differential Revision: https://phab.enlightenment.org/D1069

Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
This commit is contained in:
Rajeev Ranjan 2014-06-20 10:12:03 +02:00 committed by Cedric BAIL
parent 301b672b3a
commit 7a35f5ffdb
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/lib/eina/eina_rectangle.c
View File

@ -658,17 +658,13 @@ EAPI void
eina_rectangle_pool_free(Eina_Rectangle_Pool *pool)
{
Eina_Rectangle_Alloc *del;
Eina_List *l;
Eina_Rectangle *r;
EINA_SAFETY_ON_NULL_RETURN(pool);
DBG("pool=%p, size=(%d, %d), references=%u",
pool, pool->w, pool->h, pool->references);
EINA_LIST_FOREACH(pool->empty, l, r)
{
eina_rectangle_free(r);
pool->empty = eina_list_remove_list(pool->empty, l);
}
EINA_LIST_FREE(pool->empty, r)
eina_rectangle_free(r);
while (pool->head)
{
del = (Eina_Rectangle_Alloc *)pool->head;