enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

edje/style: Remove redundant style tags from style text. 

Summary:
Both font and font_size are already added into the style text
in _edje_format_reparse() function and there we update the tag->font_size
as well as tag->font member. so I think it is unnecessary to
add again which has memory as well as parsing performance impact.

Note :
   someone please update this cryptic comment
   /* Add font name last to save evas from multiple loads */
   how this is going to help saving multiple load.

Reviewers: ali.alzyod, Hermet, raster, cedric

Reviewed By: Hermet

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9543
This commit is contained in:
subhransu mohanty 2019-08-13 11:17:28 +09:00 committed by Hermet Park
parent 742b7afb40
commit 7ab04abf27
1 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/lib/edje/edje_textblock_styles.c
View File

@ -515,22 +515,6 @@ _edje_textblock_style_parse_and_fix(Edje_File *edf)
eina_strbuf_append(txt, fontsource);
}
}
if (tag->font_size > 0)
{
char font_size[32];
snprintf(font_size, sizeof(font_size), "%f", tag->font_size);
eina_strbuf_append(txt, " ");
eina_strbuf_append(txt, "font_size=");
eina_strbuf_append(txt, font_size);
}
/* Add font name last to save evas from multiple loads */
if (tag->font)
{
eina_strbuf_append(txt, " ");
eina_strbuf_append(txt, "font=");
eina_strbuf_append_escaped(txt, tag->font);
}
eina_strbuf_append(txt, "'");
}
if (fontset) free(fontset);