enlightenment/efl
enlightenment
/
efl
8
7
Fork 15
Code Issues 12 Pull Requests 2 Projects Releases Wiki Activity

key binding: define Elm_Action function as having a return type of Eina_Bool 

Summary:
This patch makes func of Elm_Action struct return a Eina_Bool value.
The function had a return type of void,
so could not check if the function succeeds or fails.

Test Plan: None

Reviewers: Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D666
This commit is contained in:
Jaeun Choi 2014-03-27 08:56:37 +09:00 committed by ChunEon Park
parent 559d81a871
commit 8024f3bd5a
4 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
legacy/elementary/src/lib/elm_button.c
View File

@ -41,7 +41,7 @@ static const Elm_Layout_Part_Alias_Description _text_aliases[] =
{NULL, NULL}
};
static void _key_action_activate(Evas_Object *obj, const char *params);
static Eina_Bool _key_action_activate(Evas_Object *obj, const char *params);
static const Elm_Action key_actions[] = {
{"activate", _key_action_activate},
@ -156,10 +156,12 @@ _elm_button_elm_container_content_set(Eo *obj, Elm_Button_Data *_pd EINA_UNUSED,
return EINA_TRUE;
}
static void _key_action_activate(Evas_Object *obj, const char *params EINA_UNUSED)
static Eina_Bool
_key_action_activate(Evas_Object *obj, const char *params EINA_UNUSED)
{
elm_layout_signal_emit(obj, "elm,anim,activate", "elm");
_activate(obj);
return EINA_TRUE;
}
EOLIAN static Eina_Bool

5
legacy/elementary/src/lib/elm_config.c
View File

@ -2167,10 +2167,7 @@ _elm_config_key_binding_call(Evas_Object *obj,
while (actions[i].name)
{
if (!strcmp(binding->action, actions[i].name))
{
actions[i].func(obj, binding->params);
return EINA_TRUE;
}
return actions[i].func(obj, binding->params);
i++;
}
break;

6
legacy/elementary/src/lib/elm_panel.c
View File

@ -20,7 +20,7 @@ static const Evas_Smart_Cb_Description _smart_callbacks[] = {
{NULL, NULL}
};
void _key_action_toggle(Evas_Object *obj, const char *params);
static Eina_Bool _key_action_toggle(Evas_Object *obj, const char *params);
static const Elm_Action key_actions[] = {
{"toggle", _key_action_toggle},
@ -237,9 +237,11 @@ _panel_toggle(void *data EINA_UNUSED,
edje_object_message_signal_process(wd->resize_obj);
}
void _key_action_toggle(Evas_Object *obj, const char *params EINA_UNUSED)
static Eina_Bool
_key_action_toggle(Evas_Object *obj, const char *params EINA_UNUSED)
{
_panel_toggle(NULL, obj, NULL, NULL);
return EINA_TRUE;
}
EOLIAN static Eina_Bool

2
legacy/elementary/src/lib/elm_widget.h
View File

@ -508,7 +508,7 @@ struct _Elm_Access_Info
struct _Elm_Action
{
const char *name;
void (*func)(Evas_Object *obj, const char *params);
Eina_Bool (*func)(Evas_Object *obj, const char *params);
};
void _elm_access_shutdown();