enlightenment/efl
enlightenment
/
efl
8
7
Fork 15
Code Issues 13 Pull Requests 2 Projects Releases Wiki Activity

[elementary] Fixing list clearing inside item selection for 

genlists.
When the items are made invalid, don't access rotten pointers! I think
I did it right, but it exposes a bug on genlist test 2, elementary
test. I'll let that fix to the authors of that specific code
(insert_after() and such).



SVN revision: 62763
This commit is contained in:
Gustavo Lima Chaves 2011-08-24 21:03:37 +00:00
parent 2e45192ffe
commit 802a12781f
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
legacy/elementary/src/lib/elm_genlist.c
View File

@ -826,6 +826,8 @@ _item_del(Elm_Genlist_Item *it)
static void
_item_select(Elm_Genlist_Item *it)
{
Evas_Object *parent = it->base.widget;
if ((it->wd->no_select) || (it->delete_me) || (it->mode_view)) return;
if (it->selected)
{
@ -835,25 +837,31 @@ _item_select(Elm_Genlist_Item *it)
it->selected = EINA_TRUE;
it->wd->selected = eina_list_append(it->wd->selected, it);
call:
evas_object_ref(it->base.widget);
evas_object_ref(parent);
it->walking++;
it->wd->walking++;
if (it->func.func) it->func.func((void *)it->func.data, it->base.widget, it);
if (it->func.func) it->func.func((void *)it->func.data, parent, it);
if (!it->delete_me)
evas_object_smart_callback_call(it->base.widget, SIG_SELECTED, it);
evas_object_smart_callback_call(parent, SIG_SELECTED, it);
it->walking--;
it->wd->walking--;
if ((it->wd->clear_me) && (!it->wd->walking))
elm_genlist_clear(it->base.widget);
{
elm_genlist_clear(parent);
goto end;
}
else
{
if ((!it->walking) && (it->delete_me))
{
if (!it->relcount) _item_del(it);
goto end;
}
}
it->wd->last_selected_item = it;
evas_object_unref(it->base.widget);
end:
evas_object_unref(parent);
}
static void