From 81441638dbff9f5e0c15a54d8142cdbd21582ce1 Mon Sep 17 00:00:00 2001
From: Daniel Kolesa <d.kolesa@samsung.com>
Date: Tue, 17 Sep 2019 12:36:13 +0200
Subject: [PATCH] eolian: enable unimplemented function errors for stable API

---
 src/lib/efl_mono/efl_mono_model_internal_child.eo | 2 +-
 src/lib/eolian/database_validate.c                | 6 ------
 src/tests/eolian/data/object_impl_add.eo          | 4 ++++
 src/tests/eolian/data/object_impl_add_ref.c       | 6 ++++++
 src/tests/eolian/data/parts.eo                    | 4 ++++
 5 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/src/lib/efl_mono/efl_mono_model_internal_child.eo b/src/lib/efl_mono/efl_mono_model_internal_child.eo
index ec8d657ca4..eebb79794c 100644
--- a/src/lib/efl_mono/efl_mono_model_internal_child.eo
+++ b/src/lib/efl_mono/efl_mono_model_internal_child.eo
@@ -1,4 +1,4 @@
-class Efl.Mono_Model_Internal_Child extends Efl.Loop_Consumer implements Efl.Model
+class @beta Efl.Mono_Model_Internal_Child extends Efl.Loop_Consumer implements Efl.Model
 {
   implements {
     Efl.Object.constructor;
diff --git a/src/lib/eolian/database_validate.c b/src/lib/eolian/database_validate.c
index b4a9a41053..196ab5bb88 100644
--- a/src/lib/eolian/database_validate.c
+++ b/src/lib/eolian/database_validate.c
@@ -12,7 +12,6 @@ typedef struct _Validate_State
 {
    Eina_Bool warned;
    Eina_Bool stable;
-   Eina_Bool unimplemented;
    Eina_Bool unimplemented_beta;
 } Validate_State;
 
@@ -913,10 +912,6 @@ _db_check_implemented(Validate_State *vals, Eolian_Class *cl, Eina_Hash *fs,
 
    Eina_Bool succ = EINA_TRUE;
 
-   /* unimplemented checks are not enabled for any objects */
-   if (!vals->unimplemented)
-     return EINA_TRUE;
-
    /* class is beta and we didn't enable unimplemented checking for those */
    if (!vals->unimplemented_beta && cl->base.is_beta)
      return EINA_TRUE;
@@ -1476,7 +1471,6 @@ database_validate(const Eolian_Unit *src)
    Validate_State vals = {
       EINA_FALSE,
       EINA_TRUE,
-      !!getenv("EOLIAN_CLASS_UNIMPLEMENTED_WARN"),
       !!getenv("EOLIAN_CLASS_UNIMPLEMENTED_BETA_WARN")
    };
 
diff --git a/src/tests/eolian/data/object_impl_add.eo b/src/tests/eolian/data/object_impl_add.eo
index 14888b2c4f..c1e82e2365 100644
--- a/src/tests/eolian/data/object_impl_add.eo
+++ b/src/tests/eolian/data/object_impl_add.eo
@@ -13,4 +13,8 @@ class Object_Impl_Add extends Base {
          }
       }
    }
+
+   implements {
+      Base.constructor;
+   }
 }
diff --git a/src/tests/eolian/data/object_impl_add_ref.c b/src/tests/eolian/data/object_impl_add_ref.c
index 1ccb10236d..f6b8fa5927 100644
--- a/src/tests/eolian/data/object_impl_add_ref.c
+++ b/src/tests/eolian/data/object_impl_add_ref.c
@@ -87,4 +87,10 @@ _object_impl_add_c_get(const Eo *obj, Object_Impl_Data *pd)
 
 }
 
+EOLIAN static void
+_object_impl_add_base_constructor(Eo *obj, Object_Impl_Data *pd)
+{
+
+}
+
 #include "object_impl_add.eo.c"
diff --git a/src/tests/eolian/data/parts.eo b/src/tests/eolian/data/parts.eo
index 7f925afbac..26897e152d 100644
--- a/src/tests/eolian/data/parts.eo
+++ b/src/tests/eolian/data/parts.eo
@@ -3,4 +3,8 @@ class Parts extends Override {
       part1: Override; [[Part 1]]
       part2 @beta: Parts; [[Part 2]]
    }
+   implements {
+      Override.a { set; }
+      Override.foo;
+   }
 }