enlightenment/efl
enlightenment
/
efl
8
7
Fork 15
Code Issues 12 Pull Requests 2 Projects Releases Wiki Activity

ecore_exe: fix memory leak on realloc. 

Summary: Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>

Reviewers: cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D3091

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
This commit is contained in:
Srivardhan Hebbar 2015-09-23 14:03:27 -07:00 committed by Cedric BAIL
parent fc454e4670
commit 826998c15e
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/lib/ecore/ecore_exe_posix.c
View File

@ -1095,7 +1095,7 @@ _ecore_exe_data_generic_handler(void *data,
if ((fd_handler)
&& (ecore_main_fd_handler_active_get(fd_handler, ECORE_FD_READ)))
{
unsigned char *inbuf;
unsigned char *inbuf, *temp;
int inbuf_num;
/* Get any left over data from last time. */
@ -1135,9 +1135,15 @@ _ecore_exe_data_generic_handler(void *data,
}
if (num > 0) /* data got read. */
{
temp = inbuf;
inbuf = realloc(inbuf, inbuf_num + num);
memcpy(inbuf + inbuf_num, buf, num);
inbuf_num += num;
if (inbuf)
{
memcpy(inbuf + inbuf_num, buf, num);
inbuf_num += num;
}
else // realloc fails and returns NULL.
inbuf = temp;
}
else
{ /* No more data to read. */