enlightenment/efl
enlightenment
/
efl
8
7
Fork 15
Code Issues 13 Pull Requests 2 Projects Releases Wiki Activity

From: Kim Shinwoo <kimcinoo.efl@gmail.com> 

Subject: [E-devel] [patch][elementary] dayselector - focus chain, and
about accessibility policy.

dayselector does not work in focus cycle because there is no
focus_chain().
because dayselctor is a child of Elm_Layout_Smart_Class, so it is
enough to
use focus_chain() of layout.

and.. very carefully..
i'd like to raise an issue that currently visually impaired person
should
be obliged to click(tap) quickly two times to activate widget such as
button, check.
the implementation to check 2nd click in elm_access is great. but one
single click is enough to activate button or change state of elm_check.
moreover some widgets like dayselector which has customized style for
elm_check does not work properly, because they do something at signal
'mouse,down,1'.



SVN revision: 74649
This commit is contained in:
Kim Shinwoo 2012-07-31 12:24:58 +00:00 committed by Carsten Haitzler
parent 0991e35a4c
commit 82b68bd53d
2 changed files with 4 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
legacy/elementary/src/lib/elm_check.c
View File

@ -72,10 +72,6 @@ _activate(Evas_Object *obj)
{
ELM_CHECK_DATA_GET(obj, sd);
if ((_elm_config->access_mode != ELM_ACCESS_MODE_OFF) &&
(!_elm_access_2nd_click_timeout(obj)))
return;
sd->state = !sd->state;
if (sd->statep) *sd->statep = sd->state;
if (sd->state)

23
legacy/elementary/src/lib/elm_dayselector.c
View File

@ -96,20 +96,6 @@ _dayselector_resize(void *data,
elm_layout_sizing_eval(data);
}
#if 0
static Eina_Bool
_elm_dayselector_smart_focus_next(const Evas_Object *obj,
Elm_Focus_Direction dir __UNUSED__,
Evas_Object **next __UNUSED__)
{
ELM_DAYSELECTOR_DATA_GET(obj, sd);
/* TODO: Focus switch support to Elm_widget_Item is not supported yet.*/
return EINA_FALSE;
}
#endif
static Eina_Bool
_elm_dayselector_smart_translate(Evas_Object *obj)
{
@ -453,6 +439,10 @@ _items_create(Evas_Object *obj)
snprintf(buf, sizeof(buf), "day%d", idx);
elm_layout_content_set(obj, buf, chk);
// XXX: ACCESS
_elm_access_text_set(_elm_access_object_get(chk),
ELM_ACCESS_TYPE, E_("day selector item"));
}
_items_style_set(obj);
@ -505,11 +495,6 @@ _elm_dayselector_smart_set_user(Elm_Layout_Smart_Class *sc)
ELM_WIDGET_CLASS(sc)->theme = _elm_dayselector_smart_theme;
ELM_WIDGET_CLASS(sc)->translate = _elm_dayselector_smart_translate;
#if 0
ELM_WIDGET_CLASS(sc)->focus_next = _elm_dayselector_smart_focus_next;
#else
ELM_WIDGET_CLASS(sc)->focus_next = NULL;
#endif
ELM_WIDGET_CLASS(sc)->focus_direction = NULL;