enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 1 Projects Releases Wiki Activity

genlist: scroll to item when calc is done 

Summary:
If elm_genlist_item_bring_in() is called immediately after appending
item, genlist will not scroll to the last one but stop in the middle.
This patch blocks genlist from scrolling to not calculated item.

Test Plan:
1. Download F31560 and uncompress the file
2. make
3. ./test

Reviewers: SanghyeonLee

Subscribers: cedric, DaveMDS, jpeg

Differential Revision: https://phab.enlightenment.org/D4023

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
This commit is contained in:
Jee-Yong Um 2016-06-23 10:09:13 -07:00 committed by Cedric BAIL
parent 7908431178
commit 834dd49944
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/lib/elementary/elm_genlist.c
View File

@ -581,6 +581,8 @@ _item_scroll(Elm_Genlist_Data *sd)
dw = it->item->block->w;
dh = oh;
if (dw < 1) return;
switch (sd->scroll_to_type)
{
case ELM_GENLIST_ITEM_SCROLLTO_TOP:
@ -6947,6 +6949,19 @@ _elm_genlist_item_coordinates_calc(Elm_Gen_Item *it,
return EINA_FALSE;
}
}
if (it->item->block->w < 1)
{
sd->check_scroll = EINA_TRUE;
sd->show_item = it;
sd->bring_in = bring_in;
sd->scroll_to_type = type;
it->item->show_me = EINA_TRUE;
ecore_job_del(sd->calc_job);
sd->calc_job = ecore_job_add(_calc_job, sd->obj);
return EINA_FALSE;
}
if (sd->show_item)
{
sd->show_item->item->show_me = EINA_FALSE;