enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 6 Projects Releases Wiki Activity

ecore-wl2: Fix resource leak 

Coverity detected a resource leak here because we were not freeing the
malloc'd 'obo' variable.

Fixes Coverity CID1382907

Signed-off-by: Chris Michael <cp.michael@samsung.com>
This commit is contained in:
Chris Michael 2017-11-26 12:12:53 -05:00
parent 5abeeb980a
commit 83c292ffc4
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/lib/ecore_wl2/ecore_wl2_buffer.c
View File

@ -428,7 +428,12 @@ _vc4_alloc(Buffer_Manager *self EINA_UNUSED, const char *name EINA_UNUSED, int w
memset(&bo, 0, sizeof(bo));
bo.size = size;
ret = ioctl(drm_fd, DRM_IOCTL_VC4_CREATE_BO, &bo);
if (ret) return NULL;
if (ret)
{
free(obo);
return NULL;
}
obo->handle = bo.handle;
obo->size = size;
/* First try to allocate an mmapable buffer with O_RDWR,
@ -449,6 +454,7 @@ err:
memset(&cl, 0, sizeof(cl));
cl.handle = bo.handle;
ioctl(drm_fd, DRM_IOCTL_GEM_CLOSE, &cl);
free(obo);
return NULL;
}