enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

Gengrid : Fix memory leak in elm_gengrid_realized_items_update 

Summary:
Eina_List from elm_gengrid_realized_items_get must be freed by caller,
         but elm_gengrid_realized_items_update doesn't free Eina_List.
         So memory leak is happens.
@fix

Test Plan: Call elm_gengrid_realized_items_update repeatly and check memory share increase.

Reviewers: raster, seoz

Differential Revision: https://phab.enlightenment.org/D1903
This commit is contained in:
VBS 2015-02-04 08:30:06 +09:00 committed by Daniel Juyung Seo
parent 2a3224cf5d
commit 8570190563
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
legacy/elementary/src/lib/elm_gengrid.c
View File

@ -4109,11 +4109,11 @@ _elm_gengrid_realized_items_get(Eo *obj EINA_UNUSED, Elm_Gengrid_Data *sd)
EOLIAN static void
_elm_gengrid_realized_items_update(Eo *obj, Elm_Gengrid_Data *_pd EINA_UNUSED)
{
Eina_List *list, *l;
Eina_List *list;
Elm_Object_Item *it;
list = elm_gengrid_realized_items_get(obj);
EINA_LIST_FOREACH(list, l, it)
EINA_LIST_FREE(list, it)
elm_gengrid_item_update(it);
}