From 85e55ed89de7a471a26b357ad042cf980105f747 Mon Sep 17 00:00:00 2001 From: Subodh Kumar Date: Wed, 29 Jul 2015 21:18:17 +0200 Subject: [PATCH] elm: simulate the clicked event over the object only. Summary: Two different behaviour are observed with clicked event. 1. When scroller is not present: a. Mouse down over object, b. mouse move outside the object c. mouse up, clicked happens 2. When scroller is present: a. Mouse down over object, b. mouse move outside the object c. mouse up, clicked NOT happens So clicked callback should happen over the object only i.e when mouse move out of the objcet clicked should be ignored, and behaviour will be consistent @fix Test Plan: NA Reviewers: shilpasingh, cedric Differential Revision: https://phab.enlightenment.org/D2856 Signed-off-by: Cedric BAIL --- legacy/elementary/src/lib/elm_image.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/legacy/elementary/src/lib/elm_image.c b/legacy/elementary/src/lib/elm_image.c index 17e54cc08b..f1b7b57962 100644 --- a/legacy/elementary/src/lib/elm_image.c +++ b/legacy/elementary/src/lib/elm_image.c @@ -67,10 +67,13 @@ _on_mouse_up(void *data, Evas_Object *obj EINA_UNUSED, void *event_info) { + ELM_WIDGET_DATA_GET_OR_RETURN(data, wd); + Evas_Event_Mouse_Up *ev = event_info; if (ev->button != 1) return; if (ev->event_flags & EVAS_EVENT_FLAG_ON_HOLD) return; + if (!wd->still_in) return; eo_do(data, eo_event_callback_call(EVAS_CLICKABLE_INTERFACE_EVENT_CLICKED, NULL)); }