enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 1 Projects Releases Wiki Activity

Fix a memory leak if the local bundle is NULL. 

Use a generic FAIL error when the local bundle is NULL.
Return a more detailed error report from the type add function.


SVN revision: 15839
This commit is contained in:
rbdpngn 2005-07-20 14:21:40 +00:00 committed by rbdpngn
parent fc1a4a2027
commit 85f1d386d8
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
legacy/ecore/src/lib/ecore_config/ecore_config.c
View File

@ -549,6 +549,7 @@ ecore_config_typed_val(Ecore_Config_Prop * e, const void *val, int type)
static int
ecore_config_typed_add(const char *key, const void *val, int type)
{
int error = ECORE_CONFIG_ERR_SUCC;
Ecore_Config_Prop *e;
Ecore_Config_Bundle *t;
@ -561,23 +562,29 @@ ecore_config_typed_add(const char *key, const void *val, int type)
memset(e, 0, sizeof(Ecore_Config_Prop));
if (!(e->key = strdup(key)))
goto ret_free_nte;
{
error = ECORE_CONFIG_ERR_OOM;
goto ret_free_nte;
}
if (ecore_config_typed_val(e, val, type) == ECORE_CONFIG_ERR_OOM)
if ((error = ecore_config_typed_val(e, val, type) != ECORE_CONFIG_ERR_SUCC))
goto ret_free_key;
e->next = t ? t->data : NULL;
if (t)
t->data = e;
return ECORE_CONFIG_ERR_SUCC;
{
t->data = e;
return ECORE_CONFIG_ERR_SUCC;
}
ret_free_key:
free(e->key);
ret_free_nte:
free(e);
ret:
return ECORE_CONFIG_ERR_OOM;
if (error == ECORE_CONFIG_ERR_SUCC)
error = ECORE_CONFIG_ERR_FAIL;
return error;
}
static int