enlightenment/efl
enlightenment
/
efl
8
7
Fork 15
Code Issues 12 Pull Requests 1 Projects Releases Wiki Activity

Eo: don't va_start without a matching va_end. 

Fixes coverity CID1099708.
This commit is contained in:
Tom Hacohen 2013-09-30 14:07:20 +01:00
parent 642e4293ff
commit 8ca320a1fc
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/lib/eo/eo.c
View File

@ -380,18 +380,22 @@ eo_do_internal(const char *file, int line, const Eo *obj_id, ...)
va_list p_list; va_list p_list;
Eina_Bool class_ref = _eo_is_a_class(obj_id); Eina_Bool class_ref = _eo_is_a_class(obj_id);
va_start(p_list, obj_id);
if (class_ref) if (class_ref)
{ {
EO_CLASS_POINTER_RETURN_VAL(obj_id, klass, EINA_FALSE); EO_CLASS_POINTER_RETURN_VAL(obj_id, klass, EINA_FALSE);
va_start(p_list, obj_id);
ret = _eo_class_dov_internal(file, line, klass, &p_list); ret = _eo_class_dov_internal(file, line, klass, &p_list);
va_end(p_list);
} }
else else
{ {
EO_OBJ_POINTER_RETURN_VAL(obj_id, obj, EINA_FALSE); EO_OBJ_POINTER_RETURN_VAL(obj_id, obj, EINA_FALSE);
va_start(p_list, obj_id);
ret = _eo_obj_dov_internal(file, line, obj, &p_list); ret = _eo_obj_dov_internal(file, line, obj, &p_list);
va_end(p_list);
} }
va_end(p_list);
return ret; return ret;
} }