enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

ecore_file_monitor: replace EINA_LIST_FOREACH to EINA_LIST_FOREACH_SAFE 

If ecore_file_monitor_del is called inside the file monitor callback function,
eina_list found from monitor_hash would be freed. (You can check this inside
eina_hash_list_remove.)
Then, EINA_LIST_FOREACH makes one more for loop with invalid eina_list pointer.

EINA_LIST_FOREACH_SAFE can prevent from this problem.
This commit is contained in:
WooHyun Jung 2018-01-15 13:54:01 +09:00
parent 487f2a5f81
commit 9fc1dd1a4e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/ecore_file/ecore_file_monitor_inotify.c
View File

@ -153,7 +153,7 @@ ecore_file_monitor_backend_del(Ecore_File_Monitor *em)
static Eina_Bool
_ecore_file_monitor_inotify_handler(void *data EINA_UNUSED, Ecore_Fd_Handler *fdh)
{
Eina_List *l, *ll;
Eina_List *l, *ll, *ll2;
Ecore_File_Monitor *em;
char buffer[16384];
struct inotify_event *event;
@ -173,7 +173,7 @@ _ecore_file_monitor_inotify_handler(void *data EINA_UNUSED, Ecore_Fd_Handler *fd
i += event_size;
l = _ecore_file_monitor_inotify_monitor_find(event->wd);
EINA_LIST_FOREACH(l, ll, em)
EINA_LIST_FOREACH_SAFE(l, ll, ll2, em)
_ecore_file_monitor_inotify_events(em, (event->len ? event->name : NULL), event->mask);
}