evas - Re: [E-devel] [PATCH] [EVAS] evas_object_key_grab add check for same modifiers

Hi all,

I had prepare some fix for evas_object_key_grab function.

In my opinion when given modifiers are equal it should return FALSE.

Please verify attached file.

Regards,

Patrick

Signed-Off-By: Patryk Kaczmarek<patryk.k@samsung.com>




SVN revision: 79563

AUTHORS

@@ -110,7 +110,7 @@ Sohyun Kim <anna1014.kim@samsung.com>
 Boris Faure <billiob@gmail.com>
 Eduardo Lima (Etrunko) <eblima@gmail.com>
 Leandro Dorileo (dorileo) <dorileo@profusion.mobi>
-
+Patryk Kaczmarek <patryk.k@samsung.com>
 
 Embryo
 ------

src/lib/evas/canvas/evas_key_grab.c

@@ -158,14 +158,20 @@ _key_grab(Eo *eo_obj, void *_pd, va_list *list)
    Evas_Key_Grab *g;
 
    Evas_Object_Protected_Data *obj = _pd;
-   if (!keyname)
-      *ret = EINA_FALSE;
+   if (((modifiers == not_modifiers) && (modifiers != 0)) || (!keyname))
+     {
+        *ret = EINA_FALSE;
+        return;
+     }
    if (exclusive)
      {
         g = evas_key_grab_find(eo_obj, obj, keyname, modifiers, not_modifiers,
                                exclusive);
         if (g)
-           *ret = EINA_FALSE;
+          {
+             *ret = EINA_FALSE;
+             return;
+          }
      }
    g = evas_key_grab_new(eo_obj, obj, keyname, modifiers, not_modifiers, exclusive);
    *ret = (!g) ? EINA_FALSE : EINA_TRUE;