enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 6 Projects Releases Wiki Activity

ecore_con,elput: fix warnings 

Summary:
elput: fix warning for unused write result
         ecore_con: fix warning for unused asprintf result

Reviewers: iscaro, devilhorns, cedric

Reviewed By: cedric

Subscribers: cedric, seoz, jpeg

Differential Revision: https://phab.enlightenment.org/D4308

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
This commit is contained in:
Bruno Dilly 2016-09-20 16:13:25 -07:00 committed by Cedric BAIL
parent 03882d5588
commit a3fba57b26
2 changed files with 24 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/lib/ecore_con/ecore_con.c
View File

@ -4487,11 +4487,18 @@ _efl_net_ip_connect_async_run(void *data, Ecore_Thread *thread EINA_UNUSED)
* parameter must be a URL with schema, otherwise it won't * parameter must be a URL with schema, otherwise it won't
* return anything. * return anything.
*/ */
char *url; Eina_Stringshare *url;
asprintf(&url, "%s://%s:%s", d->protocol == IPPROTO_UDP ? "udp" : "tcp", host, port); url = eina_stringshare_printf("%s://%s:%s", d->protocol == IPPROTO_UDP ? "udp" : "tcp", host, port);
proxies = ecore_con_libproxy_proxies_get(url); if (!url)
free(url); {
ERR("Could not assemble URL");
}
else
{
proxies = ecore_con_libproxy_proxies_get(url);
eina_stringshare_del(url);
}
} }
EINA_THREAD_CLEANUP_PUSH((Eina_Free_Cb)ecore_con_libproxy_proxies_free, proxies); EINA_THREAD_CLEANUP_PUSH((Eina_Free_Cb)ecore_con_libproxy_proxies_free, proxies);

14
src/lib/elput/elput_logind.c
View File

@ -276,7 +276,19 @@ _logind_device_release(Elput_Manager *em, uint32_t major, uint32_t minor)
static void static void
_logind_pipe_write_fd(Elput_Manager *em, int fd) _logind_pipe_write_fd(Elput_Manager *em, int fd)
{ {
write(em->input.pipe, &fd, sizeof(int)); int ret;
while (1)
{
ret = write(em->input.pipe, &fd, sizeof(int));
if (ret < 0)
{
if ((errno == EAGAIN) || (errno == EINTR))
continue;
WRN("Failed to write to input pipe");
}
break;
}
close(em->input.pipe); close(em->input.pipe);
em->input.pipe = -1; em->input.pipe = -1;
} }