enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

efl_ui/format: revert some patches to fix some regressions 

Summary:
it seems that the original patch in this case introduced a regression
where format strings ending with %% in progressbar would not be
displayed correctly. a followup patch attempted to resolve this, but
this second patch introduced another regression where some format strings
would always display 0%

fixing compiler warnings is always valued, but in the case where the
patch to fix the warning creates regressions then we will live with the
warnings instead

This reverts commit b4112b9735.
This reverts commit be770d37fb.

Subscribers: cedric, #reviewers, #committers

Tags: #efl_widgets

Differential Revision: https://phab.enlightenment.org/D6863
This commit is contained in:
Mike Blumenkrantz 2018-08-17 18:10:50 +01:00 committed by Alastair Poole
parent 6fe7e1155d
commit a96933f964
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/lib/efl/interfaces/efl_ui_format.c
View File

@ -38,7 +38,6 @@ _format_string_check(const char *fmt)
if (itr[1] == '%')
{
itr++;
ret_type = FORMAT_TYPE_STRING;
continue;
}
@ -131,7 +130,7 @@ _default_format_cb(void *data, Eina_Strbuf *str, const Eina_Value value)
}
else if (sd->format_type == FORMAT_TYPE_STATIC)
{
eina_strbuf_append(str, sd->template);
eina_strbuf_append_printf(str, sd->template);
}
else
{