From b0d9d4977df83c17013da290ca8a19eece6bdb3f Mon Sep 17 00:00:00 2001 From: "Carsten Haitzler (Rasterman)" Date: Fri, 8 Aug 2014 16:23:10 +0900 Subject: [PATCH] elm gengrid - fix CID 1222464 it's possible to have a NULL item in this code - also missing a valid return at the end (though code path never gets there). --- legacy/elementary/src/lib/elm_gengrid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/legacy/elementary/src/lib/elm_gengrid.c b/legacy/elementary/src/lib/elm_gengrid.c index cb5666acb4..120adb8a1d 100644 --- a/legacy/elementary/src/lib/elm_gengrid.c +++ b/legacy/elementary/src/lib/elm_gengrid.c @@ -2505,7 +2505,7 @@ _item_horizontal_loop(Evas_Object *obj, Elm_Focus_Direction dir) else return EINA_FALSE; } - + if (!item) return EINA_FALSE; if (sd->reorder_mode && !(sd->focused_item == item)) { _swap_items((Elm_Gen_Item *)sd->focused_item, (Elm_Gen_Item *)item, ELM_FOCUS_RIGHT); @@ -2516,6 +2516,7 @@ _item_horizontal_loop(Evas_Object *obj, Elm_Focus_Direction dir) elm_gengrid_item_selected_set(item, EINA_TRUE); return EINA_TRUE; } + return EINA_FALSE; } static Eina_Bool