enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 1 Projects Releases Wiki Activity

ecore_event: Fix a break of consistency of return data 

Summary:
This patch fixes a break of consistency of return data from ecore_event_del.
Before EFL 1.20, when calling ecore_event_add(ECORE_EVENT_SIGNAL_USER, event_data, NULL, &data);
The user data(data) is saved at event->data. and when user calls ecore_event_del(event_handler),
ecore_event_del returns event->data. However, current ecore_event_del returns pd->ev.
I think it is ABI break.

Test Plan: Execute test suite

Reviewers: cedric, raster, stefan_schmidt, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Differential Revision: https://phab.enlightenment.org/D5786
This commit is contained in:
Myoungwoon Roy, Kim 2018-02-07 13:50:24 +09:00 committed by Jaehyun Cho
parent e93f7bce30
commit b203ff1878
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/ecore/ecore_events.c
View File

@ -89,7 +89,7 @@ ecore_event_del(Ecore_Event *event)
{
void *data = NULL;
if (!event) return data;
ecore_event_message_data_get((Eo *)event, NULL, &data, NULL, NULL);
ecore_event_message_data_get((Eo *)event, NULL, NULL, NULL, &data);
_efl_loop_message_unsend((Eo *)event);
return data;
}