From beb582c5318e196d042adf0a30756bd662bb393a Mon Sep 17 00:00:00 2001 From: Sebastian Dransfeld Date: Mon, 2 Jul 2012 08:17:02 +0000 Subject: [PATCH] efreet: fix memory leak Don't allocate event structure unless we have a cache change. SVN revision: 73133 --- legacy/efreet/ChangeLog | 4 ++++ legacy/efreet/src/lib/efreet_cache.c | 5 +++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/legacy/efreet/ChangeLog b/legacy/efreet/ChangeLog index 9d31d4d669..46f09957f4 100644 --- a/legacy/efreet/ChangeLog +++ b/legacy/efreet/ChangeLog @@ -126,3 +126,7 @@ 2012-06-25 Sebastian Dransfeld * Support XDG_DESKTOP_DIR and read user-dirs.dirs + +2012-07-02 Sebastian Dransfeld + + * Fix minor memory leak in cache update handler diff --git a/legacy/efreet/src/lib/efreet_cache.c b/legacy/efreet/src/lib/efreet_cache.c index 1bebed8ed0..9e84fbc32c 100644 --- a/legacy/efreet/src/lib/efreet_cache.c +++ b/legacy/efreet/src/lib/efreet_cache.c @@ -1113,10 +1113,11 @@ cache_update_cb(void *data __UNUSED__, Ecore_File_Monitor *em __UNUSED__, if (!file) return; if (!strcmp(file, "desktop_data.update")) { - ev = NEW(Efreet_Event_Cache_Update, 1); - if (!ev) goto error; if (cache_check_change(path)) { + ev = NEW(Efreet_Event_Cache_Update, 1); + if (!ev) goto error; + IF_RELEASE(util_cache_names_key); IF_RELEASE(util_cache_hash_key);