From c46f9bec2d15f23c09caf932164f2b00ee5c0903 Mon Sep 17 00:00:00 2001 From: Daniel Kolesa Date: Wed, 25 Oct 2017 13:03:20 +0200 Subject: [PATCH] eolian: enable duplicate validation but only warn for now Use the EOLIAN_WARN_FUNC_DUPLICATES environment variable to enable those warnings. --- src/lib/eolian/database_validate.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/lib/eolian/database_validate.c b/src/lib/eolian/database_validate.c index 6635e7501a..0b1dd0e252 100644 --- a/src/lib/eolian/database_validate.c +++ b/src/lib/eolian/database_validate.c @@ -297,7 +297,8 @@ _validate_function(Eolian_Function *func, Eina_Hash *nhash) "function '%s' redefined (originally at %s:%d:%d)", func->name, ofunc->base.file, ofunc->base.line, ofunc->base.column); - return _obj_error(&func->base, buf); + if (getenv("EOLIAN_WARN_FUNC_DUPLICATES")) + _obj_error(&func->base, buf); } if (func->get_ret_type && !_validate_type(func->get_ret_type)) @@ -333,6 +334,10 @@ _validate_function(Eolian_Function *func, Eina_Hash *nhash) if (!_validate_doc(func->set_return_doc)) return EINA_FALSE; + /* just for now, when dups become errors there will be no need to check */ + if (!ofunc) + eina_hash_add(nhash, func->name, func); + return _validate(&func->base); }