enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 1 Projects Releases Wiki Activity

elm_notify: remove allow_events_set call in destructor 

Summary:
4976f1fc5276835940610b72ca4fa48776fc9410 erroneously flipped the
bool flag on this call, accidentally creating another object during
deletion which is illegal now as the notify object is now unparented
at this point which will result in a CRI error

this call was never required in the first place as the corresponding
layout object would have been deleted automatically due to widget parenting

@fix

Reviewers: cedric

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6147

Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
This commit is contained in:
Mike Blumenkrantz 2018-05-25 10:09:46 -07:00 committed by Cedric BAIL
parent cae57ff51b
commit c5fae98de5
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/elementary/elm_notify.c
View File

@ -461,8 +461,6 @@ _elm_notify_efl_canvas_group_group_del(Eo *obj, Elm_Notify_Data *sd)
edje_object_signal_callback_del_full
(sd->notify, "elm,action,hide,finished", "elm", _hide_finished_cb, obj);
elm_notify_parent_set(obj, NULL);
// Allow events set with TRUE will lead to the destruction of sd->block_events.
elm_notify_allow_events_set(obj, EINA_TRUE);
ecore_timer_del(sd->timer);
ELM_SAFE_FREE(sd->notify, evas_object_del);