enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

ecore wl2 - remove pointless sntrcpys causing warnings 

again pointless:

strcpy(dest, x); -> len - strlen(x); strncpy(dest, x, len);

code put in causing new warnings. this kind of "get rid of strcpy" is
actua;;y dangerous as it's more likely a mistake is made along the way
and bugs are added. strcpy's  should be reviewed and if ok - left
as-is. doing otherwise makes the code worse, not better and raises
risk. it now also produces warnings at compile time which creates
noise we just shouldnt' have.
This commit is contained in:
Carsten Haitzler 2019-02-14 09:31:02 +00:00
parent e39c710858
commit c695dde8c3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/ecore_wl2/ecore_wl2_input.c
View File

@ -635,9 +635,9 @@ _ecore_wl2_input_key_send(Ecore_Wl2_Input *input, Ecore_Wl2_Window *window, xkb_
ev->compose = comp_len ? ev->key + key_len + 1 : NULL;
ev->string = ev->compose;
strncpy((char *)ev->keyname, keyname, key_len + 1);
strncpy((char *)ev->key, key, name_len + 1);
if (comp_len) strncpy((char *)ev->compose, compose, comp_len +1);
strcpy((char *)ev->keyname, keyname);
strcpy((char *)ev->key, key);
if (comp_len) strcpy((char *)ev->compose, compose);
ev->window = (Ecore_Window)window;
ev->event_window = (Ecore_Window)window;