efreet: Check size of buffer and '\0' terminate

CID 1039595
2013-10-14 13:07:43 +02:00 · 2013-10-14 13:07:43 +02:00 · cc89eb2af9
parent 6b18d7b80a
commit cc89eb2af9
1 changed files with 4 additions and 1 deletions
--- a/src/bin/efreet/efreet_desktop_cache_create.c
+++ b/src/bin/efreet/efreet_desktop_cache_create.c
@ -152,7 +152,10 @@ cache_scan(const char *path, const char *base_id, int priority, int recurse, int
            if (*base_id)
                snprintf(id, sizeof(id), "%s-%s", base_id, fname);
            else
-                strcpy(id, fname);
+            {
+                strncpy(id, fname, PATH_MAX);
+                id[PATH_MAX - 1] = '\0';
+            }
            file_id = id;
        }