enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

elm/fileselector_button: null fileselector model pointer on delete 

Summary:
the data for this object may be further referenced during deletion
after this point without triggering errors, so ensure that pointers
which are accessible with api functions do not persist after deletion

@fix

Depends on D8985

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8986
This commit is contained in:
Mike Blumenkrantz 2019-05-30 13:10:53 -04:00
parent d3ef3d6af1
commit d1bc3ea258
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/lib/elementary/elc_fileselector_button.c
View File

@ -243,8 +243,7 @@ _elm_fileselector_button_efl_canvas_group_group_add(Eo *obj, Elm_Fileselector_Bu
EOLIAN static void
_elm_fileselector_button_efl_canvas_group_group_del(Eo *obj, Elm_Fileselector_Button_Data *sd)
{
if (sd->fsd.model)
efl_unref(sd->fsd.model);
efl_replace(&sd->fsd.model, NULL);
eina_stringshare_del(sd->window_title);
eina_stringshare_del(sd->fsd.path);
if (sd->fsd.selection)