enlightenment/efl
enlightenment
/
efl
8
7
Fork 15
Code Issues 12 Pull Requests 2 Projects Releases Wiki Activity

theme: Check the return value of _elm_theme_group_file_find() and do not 

pass NULL to eina_file_filename_get().

eina_file_filename_get() spits unnecessary eina error when the parameter
is null. In this case, we need to check the return of
_elm_theme_group_file_find() and do not call eina_file_filename_get()
	when the return is null. One should check the return of
	elm_theme_group_path_find().
Thank zmike for pointing this out.
This commit is contained in:
Daniel Juyung Seo 2013-12-23 14:49:50 +09:00
parent afe9c97bb2
commit d559beca4f
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
legacy/elementary/src/lib/elm_theme.c
View File

@ -856,8 +856,13 @@ EAPI const char *
elm_theme_group_path_find(Elm_Theme *th, const char *group)
{
EINA_SAFETY_ON_NULL_RETURN_VAL(group, NULL);
Eina_File *th_file = NULL;
if (!th) th = &(theme_default);
return eina_file_filename_get(_elm_theme_group_file_find(th, group));
th_file = _elm_theme_group_file_find(th, group);
if (th_file)
return eina_file_filename_get(th_file);
return NULL;
}
static Eina_List *