theme: Check the return value of _elm_theme_group_file_find() and do not
pass NULL to eina_file_filename_get(). eina_file_filename_get() spits unnecessary eina error when the parameter is null. In this case, we need to check the return of _elm_theme_group_file_find() and do not call eina_file_filename_get() when the return is null. One should check the return of elm_theme_group_path_find(). Thank zmike for pointing this out.
This commit is contained in:
parent
afe9c97bb2
commit
d559beca4f
|
@ -856,8 +856,13 @@ EAPI const char *
|
||||||
elm_theme_group_path_find(Elm_Theme *th, const char *group)
|
elm_theme_group_path_find(Elm_Theme *th, const char *group)
|
||||||
{
|
{
|
||||||
EINA_SAFETY_ON_NULL_RETURN_VAL(group, NULL);
|
EINA_SAFETY_ON_NULL_RETURN_VAL(group, NULL);
|
||||||
|
Eina_File *th_file = NULL;
|
||||||
if (!th) th = &(theme_default);
|
if (!th) th = &(theme_default);
|
||||||
return eina_file_filename_get(_elm_theme_group_file_find(th, group));
|
|
||||||
|
th_file = _elm_theme_group_file_find(th, group);
|
||||||
|
if (th_file)
|
||||||
|
return eina_file_filename_get(th_file);
|
||||||
|
return NULL;
|
||||||
}
|
}
|
||||||
|
|
||||||
static Eina_List *
|
static Eina_List *
|
||||||
|
|
Loading…
Reference in New Issue