From d84dfe2985fba2ea34f994785be4270a346045b5 Mon Sep 17 00:00:00 2001 From: Jae Yong Hwang Date: Wed, 27 Aug 2014 21:56:38 +0900 Subject: [PATCH] gengrid: Fixed item select logic when item select mode is ALWAYS. Summary: If gengrid select mode is not ELM_OBJECT_SELECT_MODE_ALWAYS, ELM_OBJECT_SELECT_MODE_ALWAYS mode for elm_genlist_item_select_mode was broken. In the item select routine, item mode(it->mode) was not checked. So, I added the check routine there. @fix Test Plan: I revised the elementary_test code and tested with that. Reviewers: raster, seoz Reviewed By: seoz Subscribers: SanghyeonLee, bluezery Differential Revision: https://phab.enlightenment.org/D1372 --- legacy/elementary/src/lib/elm_gengrid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/legacy/elementary/src/lib/elm_gengrid.c b/legacy/elementary/src/lib/elm_gengrid.c index 70bba99e46..385c1b8b89 100644 --- a/legacy/elementary/src/lib/elm_gengrid.c +++ b/legacy/elementary/src/lib/elm_gengrid.c @@ -3426,7 +3426,8 @@ _item_select(Elm_Gen_Item *it) it->selected = EINA_TRUE; sd->selected = eina_list_append(sd->selected, it); } - else if (sd->select_mode != ELM_OBJECT_SELECT_MODE_ALWAYS) + else if ((sd->select_mode != ELM_OBJECT_SELECT_MODE_ALWAYS) && + (it->select_mode != ELM_OBJECT_SELECT_MODE_ALWAYS)) return; evas_object_ref(obj);