From e309967384a28ccd8f463d63a91b06d2dcc4f8aa Mon Sep 17 00:00:00 2001 From: "Carsten Haitzler (Rasterman)" Date: Tue, 15 Oct 2013 10:45:37 +0900 Subject: [PATCH] Revert "ecore_evas: window does not go back to normal state if you set iconified to EINA_FALSE." This reverts commit 9bfb730ff57da3d8789f80256abedcbc19e98bfe. wrong! on deiconify this will now FORCE a ACTIVATE request to the wm (which asks the wm to focus the window/hilight it and make it active. might switch desktops or whatever). this is wrong. de-icoifying a windows does NOT mean ALSO activating it!. the log message also doesnt say what "go back to normal state"... means.... do they expect/INSIST windows MUSt be focused after de-iconification? that's wrong as it's a window management FOCUS policy, not something to do in the lib. --- src/modules/ecore_evas/engines/x/ecore_evas_x.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/modules/ecore_evas/engines/x/ecore_evas_x.c b/src/modules/ecore_evas/engines/x/ecore_evas_x.c index 20538ddf15..627dd15167 100644 --- a/src/modules/ecore_evas/engines/x/ecore_evas_x.c +++ b/src/modules/ecore_evas/engines/x/ecore_evas_x.c @@ -2738,10 +2738,7 @@ _ecore_evas_x_iconified_set(Ecore_Evas *ee, int on) if (on) ecore_x_icccm_iconic_request_send(ee->prop.window, edata->win_root); else - { - ecore_evas_activate(ee); - ecore_evas_show(ee); - } + ecore_evas_show(ee); } static void